Re: [PATCH 3/6] clk: mvebu: add CPU clock driver for Armada 7K/8K

[Stephen Boyd]

Quoting Gregory CLEMENT (2018-11-27 08:27:40)
> Hi Stephen,
>  
>  On ven., nov. 16 2018, Gregory CLEMENT <gregory.clement@xxxxxxxxxxx> wrote:
> 
> >>> +static int ap_cpu_clock_probe(struct platform_device *pdev)
> >>> +{
> >>> +       int ret, nclusters = 0, cluster_index = 0;
> >>> +       struct device *dev = &pdev->dev;
> >>> +       struct device_node *dn, *np = dev->of_node;
> >>> +       struct ap_cpu_clk *ap_cpu_clk;
> >>> +       struct regmap *regmap;
> >>> +
> >>> +       regmap = syscon_node_to_regmap(np->parent);
> >>
> >> Can we just call dev_get_remap() on pdev->dev.parent?
> >
> > we could do regmap = dev_get_regmap(pdev->dev.parent, NULL); instead of
> > this line. But is it really better?
> 
> Actually we can't, because we really depend on a syscon and at this
> moment there is no regmap. It is the syscon_node_to_regmap function which
> creates this regmap when needed.
> 

Ah ok. Nevermind then.