Re: [PATCH] clk: davinci: check for devm_kasprintf() failure

From: Stephen Boyd
Date: Wed Nov 28 2018 - 17:06:55 EST

Quoting Nicholas Mc Guire (2018-11-23 09:33:28)
> devm_kasprintf() may return NULL on failure of internal allocation thus
> the assignment to lpsc-> is not safe if not checked. On
> error davinci_lpsc_clk_register() returns a pointer to davinci_lpsc_clk
> which is checked with IS_ERR() so returning ERR_PTR(-ENOMEM) should be
> fine here.
> Signed-off-by: Nicholas Mc Guire <hofrat@xxxxxxxxx>
> Fixes: c6ed4d734bc7 ("clk: davinci: New driver for davinci PSC clocks")
> ---
> Problem located with experimental coccinelle script
> Patch was compile tested with: davinci_all_defconfig
> Patch is against 4.20-rc3 (localversion-next is next-20181123)

There are a bunch of other allocation issues with this driver so I'd
rather not expend the effort to review the one coccinelle script fix
here and instead I'd like to see the whole fix to this driver. Please
add proper lifetime management for all the allocations in this code.