Re: [PATCH] clk: nomadik: Change to use DEFINE_SHOW_ATTRIBUTE macro

From: Frank Lee
Date: Thu Nov 29 2018 - 00:56:19 EST


On Thu, Nov 29, 2018 at 6:12 AM Stephen Boyd <sboyd@xxxxxxxxxx> wrote:
>
> Quoting Stephen Boyd (2018-11-28 14:08:32)
> > Quoting Yangtao Li (2018-11-23 07:06:00)
> > > Use macro to simplify the code.
> > >
> > > Signed-off-by: Yangtao Li <tiny.windzz@xxxxxxxxx>
> > > ---
> >
> > Applied to clk-next
> >
>
> Except this doesn't compile. I fixed it, but please actually compile
> your patches before sending next time.
Sorry, I will pay attention next time.

MBR,
Yangtao
>
> diff --git a/drivers/clk/clk-nomadik.c b/drivers/clk/clk-nomadik.c
> index e331634d34df..a95aa96f4a68 100644
> --- a/drivers/clk/clk-nomadik.c
> +++ b/drivers/clk/clk-nomadik.c
> @@ -455,7 +455,7 @@ static const char * const src_clk_names[] = {
> "RNGCCLK ",
> };
>
> -static int nomadik_src_clk_show(struct seq_file *s, void *what)
> +static int nomadik_src_clk_debugfs_show(struct seq_file *s, void *what)
> {
> int i;
> u32 src_pcksr0 = readl(src_base + SRC_PCKSR0);