Re: [PATCH] dma-debug: hns_enet_drv could use more DMA entries

From: Christoph Hellwig
Date: Fri Nov 30 2018 - 03:42:06 EST


On Thu, Nov 29, 2018 at 10:54:56PM -0500, Qian Cai wrote:
> /* allow architectures to override this if absolutely required */
> #ifndef PREALLOC_DMA_DEBUG_ENTRIES
> +/* amount of DMA mappings on this driver is huge. */
> +#ifdef HNS_ENET
> +#define PREALLOC_DMA_DEBUG_ENTRIES (1 << 17)
> +#else
> #define PREALLOC_DMA_DEBUG_ENTRIES (1 << 16)
> #endif
> +#endif

How would this be defined in a header that leaks into this file?

I think we need to turn PREALLOC_DMA_DEBUG_ENTRIES into a user
selectable config options, as I really don't want to collect hacks like
this.