Re: [PATCH v2] fs: fix lost error code in dio_complete

[Christoph Hellwig]

Al, Jens,

can someone pick this up, please?

On Fri, Nov 30, 2018 at 10:02:22AM +0100, Maximilian Heyne wrote:
> On 11/8/18 7:58 PM, Maximilian Heyne wrote:
>> commit e259221763a40403d5bb232209998e8c45804ab8 ("fs: simplify the
>> generic_write_sync prototype") reworked callers of generic_write_sync(),
>> and ended up dropping the error return for the directio path. Prior to
>> that commit, in dio_complete(), an error would be bubbled up the stack,
>> but after that commit, errors passed on to dio_complete were eaten up.
>>
>> This was reported on the list earlier, and a fix was proposed in
>> https://lore.kernel.org/lkml/20160921141539.GA17898@xxxxxxxxxxxxx/, but
>> never followed up with.  We recently hit this bug in our testing where
>> fencing io errors, which were previously erroring out with EIO, were
>> being returned as success operations after this commit.
> I just wanted to follow up on this. Has anyone picked up this patch?
>
>
>
> Amazon Development Center Germany GmbH
> Krausenstr. 38
> 10117 Berlin
> Geschaeftsfuehrer: Christian Schlaeger, Ralf Herbrich
> Ust-ID: DE 289 237 879
> Eingetragen am Amtsgericht Charlottenburg HRB 149173 B
>
---end quoted text---