Re: [PATCH] dma-debug: hns_enet_drv could use more DMA entries

From: Robin Murphy
Date: Fri Nov 30 2018 - 07:04:52 EST


On 30/11/2018 08:42, Christoph Hellwig wrote:
On Thu, Nov 29, 2018 at 10:54:56PM -0500, Qian Cai wrote:
/* allow architectures to override this if absolutely required */
#ifndef PREALLOC_DMA_DEBUG_ENTRIES
+/* amount of DMA mappings on this driver is huge. */
+#ifdef HNS_ENET
+#define PREALLOC_DMA_DEBUG_ENTRIES (1 << 17)
+#else
#define PREALLOC_DMA_DEBUG_ENTRIES (1 << 16)
#endif
+#endif

How would this be defined in a header that leaks into this file?

Apparently it wouldn't, because nothing defines that macro anywhere anyway. CONFIG_HNS_ENET, on the other hand, would be available by virtue of autoconf.h which is just about everywhere.

I think we need to turn PREALLOC_DMA_DEBUG_ENTRIES into a user
selectable config options, as I really don't want to collect hacks like
this.

Agreed - we already have per-arch overrides scattered about, so growing special cases in yet another place just makes even more of a mess. Rounding all of it up into Kconfig would definitely make sense.

Robin.