Re: [PATCH v5 09/15] i2c: acpi: Introduce i2c_acpi_get_i2c_resource() helper
From: Andy Shevchenko
Date: Fri Nov 30 2018 - 07:18:00 EST
On Fri, Nov 30, 2018 at 02:12:31PM +0200, Mika Westerberg wrote:
> On Fri, Nov 30, 2018 at 12:49:50PM +0100, Wolfram Sang wrote:
> >
> > > > Is this something we have to live with or which can be cleaned up
> > > > somewhen?
> > >
> > > My opinion that we might need something like
> > > drivers/acpi/acpi_i2c_lib.c
> > > drivers/acpi/acpi_gpio_lib.c
> > > etc.
> > >
> >
> > Collect all of them in drivers/acpi/acpi_libs.c?
> >
> > > But better to ask Rafael and Mika what they think about this.
>
> IMHO all the bus specific ACPI things should go under those buses (so
> the opposite what is proposed here) but I also don't think any of this
> is show stopper for the patch series under discussion ;-)
Thank you guys for your input, let me fix this later, out of this series.
--
With Best Regards,
Andy Shevchenko