Re: [PATCH] perf evsel: Correct clock unit to nanosecond

From: Arnaldo Carvalho de Melo
Date: Fri Nov 30 2018 - 10:25:28 EST


Em Fri, Nov 30, 2018 at 10:21:40PM +0800, leo.yan@xxxxxxxxxx escreveu:
> On Fri, Nov 30, 2018 at 11:21:54AM +0100, Jiri Olsa wrote:
> > On Fri, Nov 30, 2018 at 06:06:05PM +0800, Leo Yan wrote:
> > > Since commit 0aa802a79469 ("perf stat: Get rid of extra clock display
> > > function"), the cpu and task clock unit has been changed from
> > > nanosecond value to millisecond value. This introduces confusion for
> > > CPU run time statistics, we can see in below flow the clock value is
> > > scaled from nanosecond value to millisecond value; but this is
> > > contradiction with statistics type 'STAT_NSECS', which always takes
> > > clock as nanosecond unit.
>
> [...]
>
> > there was fix for this recently, could you please check
> > if it's working for you:
> > 6e269c85dcea perf stat: Fix shadow stats for clock events
>
> Ah, I missed this patch ...
>
> Yeah, I tested this patch and can confirm this patch fixes
> this issue.

My fault, new notebook update process got in the way causing
acme/perf/core to pile up, a perf/core pull req is about to be sent to
Ingo now tho :-)

- Arnaldo