Re: [PATCH] dax: Fix Xarray conversion of dax_unlock_mapping_entry()

From: Matthew Wilcox
Date: Fri Nov 30 2018 - 11:24:39 EST

On Fri, Nov 30, 2018 at 07:54:49AM -0800, Dan Williams wrote:
> Looks good to me, although can we make that cookie an actual type? I
> think it's mostly ok to pass around (void *) for 'entry' inside of
> fs/dax.c, but once an entry leaves that file I'd like it to have an
> explicit type to catch people that might accidentally pass a (struct
> page *) to the unlock routine.

That's a really good idea. Something like this?

typedef struct {
void *v;
} dax_entry_t;

I could see us making good use of that within dax.c.