Re: [PATCH 3/8] socket: Disentangle SOCK_RCVTSTAMPNS from SOCK_RCVTSTAMP
From: Deepa Dinamani
Date: Fri Nov 30 2018 - 17:16:35 EST
On Sun, Nov 25, 2018 at 10:19 AM David Miller <davem@xxxxxxxxxxxxx> wrote:
>
> From: Willem de Bruijn <willemdebruijn.kernel@xxxxxxxxx>
> Date: Sun, 25 Nov 2018 09:18:55 -0500
>
> > The existing logic is as is for a reason. There is no need to change
> > it to satisfy the main purpose of your patchset?
> >
> > It is structured as one bit to test whether a timestamp is requested
> > and another to select among two variants usec/nsec. Just add another
> > layer of branching between new/old in cases where this distinction is
> > needed.
> >
> > Please avoid code churn unless needed.
>
> +1
This patch makes it easier to add logic for 2 new socket time options.
But, if you prefer for all of the options to depend on SOCK_RCVTSTAMP
then I will drop it.
-Deepa