Re: [PATCH v5 2/7] tpm: remove definition of TPM2_ACTIVE_PCR_BANKS

[Jarkko Sakkinen]

On Fri, Nov 30, 2018 at 11:45:27AM -0800, Jarkko Sakkinen wrote:
> On Fri, Nov 30, 2018 at 11:41:49AM -0800, Jarkko Sakkinen wrote:
> > Even after looking at the spec the last field does not make sense as the
> > event after digests and digests are not in union. It is just not right.
> > 
> > The comment does not fix that.
> 
> You should remove the last field and rename the struct as maybe
> struct tcg_pcr_event2_head. If we ever need the very last field
> we can create struct *_tail.
> 
> Not your fault but there is clear bug in the struct definition
> that should be fixed in a commit of its own.
> 
> No new comments are needed.

I checked and did not find the field even used anywhere. Can you
peer check this and then just remove it? And yeah maybe the struct
should have _head suffix.

/Jarkko