Re: [PATCH] PCI/P2PDMA: Match interface changes to devm_memremap_pages()

From: Dan Williams
Date: Fri Nov 30 2018 - 19:52:58 EST


On Fri, Nov 30, 2018 at 2:59 PM Logan Gunthorpe <logang@xxxxxxxxxxxx> wrote:
>
> "mm-hmm-mark-hmm_devmem_add-add_resource-export_symbol_gpl.patch" in the
> mm tree breaks p2pdma. The patch was written and reviewed before p2pdma
> was merged so the necessary changes were not done to the call site in
> that code.
>
> Without this patch, all drivers will fail to register P2P resources
> because devm_memremap_pages() will return -EINVAL due to the 'kill'
> member of the pagemap structure not yet being set.
>
> Signed-off-by: Logan Gunthorpe <logang@xxxxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Dan Williams <dan.j.williams@xxxxxxxxx>

Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx>