Re: [PATCH] prctl: add PR_{GET,SET}_KILL_DESCENDANTS_ON_EXIT

From: Kees Cook
Date: Fri Nov 30 2018 - 23:30:51 EST


On Fri, Nov 30, 2018 at 2:33 AM Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
>
> On 11/29, JÃrg Billeter wrote:
> >
> > On Thu, 2018-11-29 at 13:34 +0100, Oleg Nesterov wrote:
> > > So I think the patch is mostly fine, the only problem I can see is that
> > > PR_SET_KILL_DESCENDANTS_ON_EXIT can race with PR_SET_CHILD_SUBREAPER, they both
> > > need to update the bits in the same word.
> >
> > Good point. I'll make it a regular bool instead of a bitfield for v2,
>
> Agreed,

Is it worth doing something for singal_struct like we did for
task_struct with the TASK_PFA_* and atomic_flags?

--
Kees Cook