Re: [PATCH 2/2] hwmon: Remove multiple space after dot
From: Joe Perches
Date: Sat Dec 01 2018 - 15:35:49 EST
On Thu, 2018-11-29 at 20:09 +0000, Corentin Labbe wrote:
> This patch remove extra space after a dot.
[]
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
---
> drivers/hwmon/Kconfig | 236 +++++++++++++++++++++---------------------
> 1 file changed, 118 insertions(+), 118 deletions(-)
[]
> @@ -11,7 +11,7 @@ menuconfig HWMON
> of a system. Most modern motherboards include such a device. It
> can include temperature sensors, voltage sensors, fan speed
> sensors and various additional features such as the ability to
> - control the speed of the fans. If you want this support you
> + control the speed of the fans. If you want this support you
> should say Y here and also to the specific driver(s) for your
> sensors chip(s) below.
Please no.
You can't pry two spaces after a period when using a
fixed width font from me.
And the use is nowhere consistent in the kernel as it's
less than 2:1 in favor of one style over the other.
$ git grep -i '[a-z][a-z]\. [a-z][a-z ]' | wc -l
146888
$ git grep -i '[a-z][a-z]\. [a-z][a-z ]' | wc -l
85195
The kernel Kconfig use ratio is similar.
$ git grep -i '[a-z][a-z]\. [a-z][a-z ]' -- '*/Kconfig*' | wc -l
5389
$ git grep -i '[a-z][a-z]\. [a-z][a-z ]' -- '*/Kconfig*' | wc -l
2463
And even in this specific file, it's reversed ratio
$ git grep -i '[a-z][a-z]\. [a-z][a-z ]' -- 'drivers/hwmon/Kconfig*' | wc -l
70
$ git grep -i '[a-z][a-z]\. [a-z][a-z ]' -- 'drivers/hwmon/Kconfig*' | wc -l
129
So if you _really_ wanted to do this, please do the
entire file consistently.
You seemed to do 118 conversions. Shouldn't there be 129?