RE: [PATCH v2] x86/hyper-v: Mark TLFS structures packed

[Michael Kelley]

From: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>  Sent: Friday, November 30, 2018 4:54 AM
> 
> @@ -466,7 +466,7 @@ union hv_message_flags {
>  	struct {
>  		__u8 msg_pending:1;
>  		__u8 reserved:7;
> -	};
> +	} __packed;
>  };
> 
>  /* Define port identifier type. */

I think __packed is also needed in the definition
of struct u defined within union hv_port_id.  That
struct has bit fields, so shouldn't it be done just like
union hv_message_flags above?

Michael

> @@ -488,7 +488,7 @@ struct hv_message_header {
>  		__u64 sender;
>  		union hv_port_id port;
>  	};
> -};
> +} __packed;
>