Re: [PATCH] locktorture: Fix assignment of boolean variables
From: Peter Zijlstra
Date: Mon Dec 03 2018 - 05:51:03 EST
On Mon, Dec 03, 2018 at 10:20:42AM +0100, Julia Lawall wrote:
> Personally, I would prefer that assignments involving boolean variables
> use true or false. It seems more readable. Potentially better for tools
> as well.
Then those tools are broken per the C spec.
> But if the community really prefers 0 and 1, then the test can
> be deleted.
The C language spec, specifies _Bool as an integer type wide enough to
at least store 0 and 1.
IOW, 0 and 1 are perfectly valid valus to assign to a _Bool.
And fundamentally that has to be so. That's how computers work. 0 is
false, 1 is true.
The kernel is not the place to try and abstract such stuff, C is our
portable assembler. We muck with hardware, we'd better know how the heck
it works.