Re: [PATCH v2 5/5] x86/mm: Drop usage of __flush_tlb_all() in kernel_physical_mapping_init()

From: Dave Hansen
Date: Mon Dec 03 2018 - 12:18:58 EST


On 12/2/18 9:04 AM, Dan Williams wrote:
>> This patch on it's own doesn't apply to any of the stable trees, does it
>> maybe depend on some of the previous patches in this series?
> It does not strictly depend on them, but it does need to be rebased
> without them. The minimum patch for -stable are these
> __flush_tlb_all() removals, but without the
> set_{pte,pmd,pud,p4d,pgd}_safe() conversion. It's also an option to
> backport those helpers, and conversion but I'd defer to x86/mm folks
> to make that call.

I think we should skip backporting the helpers for now. Hopefully,
mainline will help us catch bugs with those helpers and we can get the
fixes for those bugs backported if they show up.

I mostly say this because with the addition of the 5-level paging code,
there's been a lot of churn in the area of these helpers. They will be
a mild pain to backport, and I'd expect more bugs from the backports
than from the lack of the new helpers.