Re: [PATCH] RDMA/uverbs: fix ptr_ret.cocci warnings

From: Jason Gunthorpe
Date: Mon Dec 03 2018 - 15:47:13 EST


On Mon, Dec 03, 2018 at 12:23:35PM -0500, Doug Ledford wrote:
> On Thu, 2018-11-29 at 16:37 -0700, Jason Gunthorpe wrote:
> > On Wed, Nov 28, 2018 at 07:21:30AM +0800, kbuild test robot wrote:
> > > From: kbuild test robot <fengguang.wu@xxxxxxxxx>
> > >
> > > drivers/infiniband/core/uverbs_cmd.c:1095:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> > >
> > >
> > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> > >
> > > Generated by: scripts/coccinelle/api/ptr_ret.cocci
> > >
> > > Fixes: 7106a9769715 ("RDMA/uverbs: Make write() handlers return 0 on success")
> > > Signed-off-by: kbuild test robot <fengguang.wu@xxxxxxxxx>
> >
> > applied to for-next, thanks
> >
> > Jason
>
> This caused a conflict with your make write() handlers use a consistent
> flow series, which I fixed up during git am run. Just FYI in case you
> want to check out the conflict spot as a double check (but it was a
> simple fixup).

Looks OK to me thanks

Jason