Re: [PATCH 2/3] mm/mmu_notifier: use structure for invalidate_range_start/end calls

From: Jerome Glisse
Date: Mon Dec 03 2018 - 19:09:20 EST


On Mon, Dec 03, 2018 at 03:18:16PM -0500, jglisse@xxxxxxxxxx wrote:
> diff --git a/mm/migrate.c b/mm/migrate.c
> index f7e4bfdc13b7..4896dd9d8b28 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -2303,8 +2303,13 @@ static int migrate_vma_collect_pmd(pmd_t *pmdp,
> */
> static void migrate_vma_collect(struct migrate_vma *migrate)
> {
> + struct mmu_notifier_range range;
> struct mm_walk mm_walk;
>
> + range.start = migrate->start;
> + range.end = migrate->end;
> + range.mm = mm_walk.mm;

Andrew can you replace above line by:

+ range.mm = migrate->vma->vm_mm;

I made a mistake here when i was rebasing before posting. I checked
the patchset again and i believe this is the only mistake i made.

Do you want me to repost ?

Sorry for my stupid mistake.

Cheers,
Jérôme