Re: [PATCH] tracing: add cond_resched to ftrace_replace_code()

[Anders Roxell]

On Tue, 4 Dec 2018 at 20:29, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> On Tue, 4 Dec 2018 20:25:31 +0100
> Anders Roxell <anders.roxell@xxxxxxxxxx> wrote:
>
> > On Tue, 4 Dec 2018 at 20:21, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> > >
> > > On Tue, 4 Dec 2018 14:19:08 -0500
> > > Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> > >
> > > > > @@ -2435,6 +2438,13 @@ void __weak ftrace_replace_code(int enable)
> > > > >                     /* Stop processing */
> > > > >                     return;
> > > > >             }
> > > > > +           /*
> > > > > +            * Some archs calls this function with interrupts or preemption
> > > > > +            * disabled. Howeve, other archs don't and this can cause a
> > >
> > > typo "However". But could you write it this way:
> > >
> > >         "However, for other archs that can preempt, this can cause an
> > >         tremendous unneeded latency."
> > >
> >
> > I'll fix this and move it up (where I added it in the first place but
> > moved it) =)
> >
>
> I also noticed a grammar issue:
>
>         "Some archs call this function .."

I will fix that.

Cheers,
Anders