Re: [PATCH v5 1/2] kernel/signal: Signal-based pre-coredump notification
From: Andrew Morton
Date: Tue Dec 04 2018 - 17:38:07 EST
On Wed, 28 Nov 2018 16:15:35 -0800 Enke Chen <enkechen@xxxxxxxxx> wrote:
> Thanks for your comments. You have indeed missed some of the prior reviews
> and discussions. But that is OK.
This is why it is best to update the changelog in response to the
review discussion - if person A was wondering about something then it
is likely that person B will wonder about the same thing. Take a
reviewer's questioning as an indication that the changelog was lacking.
I'm not sure what to make of this patchset, really. Oleg sounds
unhappy and that's always a bad sign. And signals are rather ugly
things. Oleg, can you please expand on your concerns?
The arguments against using connector aren't very compelling. Sure,
connector is hard to use from shell scripts but so are signals? And is
there much of a usecase for managing these things with shell scripts
anyway?
Has an eventfd implementation been considered?
I'm sure we've added other kernel->userspace comminication schemes, but
I can't immediately recall them all :(