Re: [PATCH] perf vendor events intel: Fix Load_Miss_Real_Latency on SKL/SKX

[Jiri Olsa]

On Mon, Nov 19, 2018 at 09:06:35PM -0800, Andi Kleen wrote:
> From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> 
> Fix incorrect event names for the Load_Miss_Real_Latency metric for
> Skylake and Skylake Server.
> 
> Fixes https://github.com/andikleen/pmu-tools/issues/158

Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>

thanks,
jirka

> 
> Before:
> 
> % perf stat -M Load_Miss_Real_Latency true
> event syntax error: '..ss.pending,mem_load_retired.l1_miss_ps,mem_load_retired.fb_hit_ps}:W'
>                                   \___ parser error
> 
>  Usage: perf stat [<options>] [<command>]
> 
>     -M, --metrics <metric/metric group list>
>                           monitor specified metrics or metric groups (separated by ,)
> 
> After:
> 
> % perf stat -M Load_Miss_Real_Latency true
> 
>  Performance counter stats for 'true':
> 
>            279,204      l1d_pend_miss.pending     #     14.0 Load_Miss_Real_Latency
>              4,784      mem_load_uops_retired.l1_miss
>             15,188      mem_load_uops_retired.hit_lfb
> 
>        0.000899640 seconds time elapsed
> 
> Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> ---
>  tools/perf/pmu-events/arch/x86/skylake/skl-metrics.json  | 2 +-
>  tools/perf/pmu-events/arch/x86/skylakex/skx-metrics.json | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/pmu-events/arch/x86/skylake/skl-metrics.json b/tools/perf/pmu-events/arch/x86/skylake/skl-metrics.json
> index 36c903faed0b..71e9737f4614 100644
> --- a/tools/perf/pmu-events/arch/x86/skylake/skl-metrics.json
> +++ b/tools/perf/pmu-events/arch/x86/skylake/skl-metrics.json
> @@ -73,7 +73,7 @@
>      },
>      {
>          "BriefDescription": "Actual Average Latency for L1 data-cache miss demand loads",
> -        "MetricExpr": "L1D_PEND_MISS.PENDING / ( MEM_LOAD_RETIRED.L1_MISS_PS + MEM_LOAD_RETIRED.FB_HIT_PS )",
> +        "MetricExpr": "L1D_PEND_MISS.PENDING / ( MEM_LOAD_RETIRED.L1_MISS + MEM_LOAD_RETIRED.FB_HIT )",
>          "MetricGroup": "Memory_Bound;Memory_Lat",
>          "MetricName": "Load_Miss_Real_Latency"
>      },
> diff --git a/tools/perf/pmu-events/arch/x86/skylakex/skx-metrics.json b/tools/perf/pmu-events/arch/x86/skylakex/skx-metrics.json
> index 36c903faed0b..71e9737f4614 100644
> --- a/tools/perf/pmu-events/arch/x86/skylakex/skx-metrics.json
> +++ b/tools/perf/pmu-events/arch/x86/skylakex/skx-metrics.json
> @@ -73,7 +73,7 @@
>      },
>      {
>          "BriefDescription": "Actual Average Latency for L1 data-cache miss demand loads",
> -        "MetricExpr": "L1D_PEND_MISS.PENDING / ( MEM_LOAD_RETIRED.L1_MISS_PS + MEM_LOAD_RETIRED.FB_HIT_PS )",
> +        "MetricExpr": "L1D_PEND_MISS.PENDING / ( MEM_LOAD_RETIRED.L1_MISS + MEM_LOAD_RETIRED.FB_HIT )",
>          "MetricGroup": "Memory_Bound;Memory_Lat",
>          "MetricName": "Load_Miss_Real_Latency"
>      },
> -- 
> 2.17.2
>