Re: [PATCH] dmaengine: remove DBGFS_FUNC_DECL()

[Frank Lee]

On Wed, Dec 5, 2018 at 11:59 PM Vinod Koul <vkoul@xxxxxxxxxx> wrote:
>
> On 05-12-18, 23:49, Frank Lee wrote:
> > On Wed, Dec 5, 2018 at 4:27 PM Vinod Koul <vkoul@xxxxxxxxxx> wrote:
> > >
> > > On 30-11-18, 10:42, Yangtao Li wrote:
> > > > We already have the DEFINE_SHOW_ATTRIBUTE,There is no need to define
> > > > such a macro,so remove DBGFS_FUNC_DECL.Also use macro to simplify some
> > > > code.
> > >
> > > Spaces after full stop and comma please
> > >
> > > >
> > > > Signed-off-by: Yangtao Li <tiny.windzz@xxxxxxxxx>
> > > > ---
> > > >  drivers/dma/amba-pl08x.c     | 14 ++------------
> > > >  drivers/dma/mic_x100_dma.c   | 22 +++-------------------
> > > >  drivers/dma/pxa_dma.c        | 24 ++++++++++++------------
> > > >  drivers/dma/qcom/hidma_dbg.c | 33 ++++++---------------------------
> > >
> > > Do you mind splitting it per file.
> > Hi Vinod:
> >
> > Why not apply it once ïThe change is not too big.
>
> It is not about big or small. A patch should do one thing and touch a
> single module.
>
> It also helps people when they look at changes and backports.
Already divided into small files, as you need.

MBR,
Yangtao
>
> --
> ~Vinod