Re: [PATCH] perf, tools: Support srccode output
From: Jiri Olsa
Date: Wed Dec 05 2018 - 12:05:32 EST
On Wed, Dec 05, 2018 at 01:54:30PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Dec 05, 2018 at 01:28:38PM +0100, Jiri Olsa escreveu:
> > On Mon, Dec 03, 2018 at 04:18:48PM -0800, Andi Kleen wrote:
> > > From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> > >
> > > When looking at PT or brstackinsn traces with perf script
> > > it can be very useful to see the source code. This adds a simple
> > > facility to print them with perf script, if the information
> > > is available through dwarf
> > >
> > > % perf record ...
> > > % perf script -F insn,ip,sym,srccode
> > > ...
> > >
> > > 4004c6 main
> > > 5 for (i = 0; i < 10000000; i++)
> > > 4004cd main
> > > 5 for (i = 0; i < 10000000; i++)
> > > 4004c6 main
> > > 5 for (i = 0; i < 10000000; i++)
> > > 4004cd main
> > > 5 for (i = 0; i < 10000000; i++)
> > > 4004cd main
> > > 5 for (i = 0; i < 10000000; i++)
> > > 4004cd main
> > > 5 for (i = 0; i < 10000000; i++)
> > > 4004cd main
> > > 5 for (i = 0; i < 10000000; i++)
> > > 4004cd main
> > > 5 for (i = 0; i < 10000000; i++)
> > > 4004b3 main
> > > 6 v++;
> > >
> > > % perf record -b ...
> > > % perf script -F insn,ip,sym,srccode,brstackinsn
> > >
> > > ...
> > > main+22:
> > > 0000000000400543 insn: e8 ca ff ff ff # PRED
> > > |18 f1();
> > > f1:
> > > 0000000000400512 insn: 55
> > > |10 {
> > > 0000000000400513 insn: 48 89 e5
> > > 0000000000400516 insn: b8 00 00 00 00
> > > |11 f2();
> > > 000000000040051b insn: e8 d6 ff ff ff # PRED
> > > f2:
> > > 00000000004004f6 insn: 55
> > > |5 {
> > > 00000000004004f7 insn: 48 89 e5
> > > 00000000004004fa insn: 8b 05 2c 0b 20 00
> > > |6 c = a / b;
> > > 0000000000400500 insn: 8b 0d 2a 0b 20 00
> > > 0000000000400506 insn: 99
> > > 0000000000400507 insn: f7 f9
> > > 0000000000400509 insn: 89 05 29 0b 20 00
> > > 000000000040050f insn: 90
> > > |7 }
> > > 0000000000400510 insn: 5d
> > > 0000000000400511 insn: c3 # PRED
> > > f1+14:
> > > 0000000000400520 insn: b8 00 00 00 00
> > > |12 f2();
> > > 0000000000400525 insn: e8 cc ff ff ff # PRED
> > > f2:
> > > 00000000004004f6 insn: 55
> > > |5 {
> > > 00000000004004f7 insn: 48 89 e5
> > > 00000000004004fa insn: 8b 05 2c 0b 20 00
> > > |6 c = a / b;
> > >
> > > Not supported for callchains currently, would need some
> > > layout changes there.
> >
> > nice, works nicely, especialy with --xed
>
> The above seems to imply you actually tested it, was that the case? Can
> you please provide me the exact 'perf record' line you used, that is
> lacking in Andi's original commit log message?
yep..
# ./perf record -e intel_pt//u -- ./perf
jirka