Re: [PATCH 3/9] tools/lib/traceevent: Install trace-seq.h API header file

[Jiri Olsa]

On Wed, Dec 05, 2018 at 12:03:34PM -0500, Steven Rostedt wrote:
> On Wed, 5 Dec 2018 13:25:17 +0100
> Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
> 
> > On Tue, Dec 04, 2018 at 02:41:45PM -0500, Steven Rostedt wrote:
> > > On Tue, 4 Dec 2018 16:47:39 +0900
> > > Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
> > > 
> > >   
> > > > > @@ -302,6 +302,7 @@ install_headers:
> > > > >  	$(call QUIET_INSTALL, headers) \
> > > > >  		$(call do_install,event-parse.h,$(prefix)/include/traceevent,644); \
> > > > >  		$(call do_install,event-utils.h,$(prefix)/include/traceevent,644); \
> > > > > +		$(call do_install,trace-seq.h,$(prefix)/include/traceevent,644); \
> > > > >  		$(call do_install,kbuffer.h,$(prefix)/include/traceevent,644)    
> > > > 
> > > > Do you still wanna have 'traceevent' directory prefix?  I just
> > > > sometimes feel a bit annoying to type it. ;-)  
> > > 
> > > I'd still want the separate directory for it. I'll probably have a
> > > ftrace.h file added to this for ftrace specific code in the future.
> > >   
> > > > 
> > > > Or you can rename it something like 'tep' or 'libtep' - and hopefully
> > > > having only single header file to include..
> > > >  
> > > 
> > > Hmm, I wonder if we should just call the directory "trace"?  
> > 
> > hum, I think it should match the library name, like 'include/tep/'
> 
> I was hoping to add other headers in this directly, like ftrace.h and
> perf.h ;-)

those are headers from trace-cmd?

I guess we could have some common 'trace' related directory,
but I think we should have some rules for placing files in
there to avoid mayhem ;-)

but I'd prefer to go with package related directories under include

> > also we should change the plugin installation directory
> > 
> > [jolsa@krava traceevent]$ rpm -ql perf | grep traceevent
> > /usr/lib64/traceevent
> > /usr/lib64/traceevent/plugins
> > /usr/lib64/traceevent/plugins/plugin_cfg80211.so
> > /usr/lib64/traceevent/plugins/plugin_function.so
> > /usr/lib64/traceevent/plugins/plugin_hrtimer.so
> > /usr/lib64/traceevent/plugins/plugin_jbd2.so
> > /usr/lib64/traceevent/plugins/plugin_kmem.so
> > /usr/lib64/traceevent/plugins/plugin_kvm.so
> > /usr/lib64/traceevent/plugins/plugin_mac80211.so
> > /usr/lib64/traceevent/plugins/plugin_sched_switch.so
> > /usr/lib64/traceevent/plugins/plugin_scsi.so
> > /usr/lib64/traceevent/plugins/plugin_xen.so
> 
> Change it to tep?

yes, that makes sense to me

jirka