RE: [PATCH 1/3] ARM: dts: imx6qdl-sabresd: add light sensor support

[Anson Huang]

Hi, Fabio

Best Regards!
Anson Huang

> -----Original Message-----
> From: Fabio Estevam [mailto:festevam@xxxxxxxxx]
> Sent: 2018å12æ5æ 20:15
> To: Anson Huang <anson.huang@xxxxxxx>
> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>; Sascha Hauer
> <s.hauer@xxxxxxxxxxxxxx>; Sascha Hauer <kernel@xxxxxxxxxxxxxx>; Fabio
> Estevam <fabio.estevam@xxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>;
> Mark Rutland <mark.rutland@xxxxxxx>; moderated list:ARM/FREESCALE IMX
> / MXC ARM ARCHITECTURE <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>; open
> list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> <devicetree@xxxxxxxxxxxxxxx>; linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>;
> dl-linux-imx <linux-imx@xxxxxxx>
> Subject: Re: [PATCH 1/3] ARM: dts: imx6qdl-sabresd: add light sensor support
> 
> Hi Anson,
> 
> On Wed, Dec 5, 2018 at 7:20 AM Anson Huang <anson.huang@xxxxxxx>
> wrote:
> >
> > Add isl29023 light sensor support on i2c3 bus, the light sensor's
> > power is controlled by a fixed regulator, since the isl29023 driver
> > and most of other sensors on same board like mag3110 and mma8451 do
> > NOT support regulator operation currently, they are all controlled by
> > this regulator, so this patch also adds the fixed regulator support
> > and make it always on.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>
> > ---
> >  arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 34
> > ++++++++++++++++++++++++++++++++++
> >  1 file changed, 34 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> > b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> > index d7389b5..f96ae54 100644
> > --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> > @@ -62,6 +62,19 @@
> >                         gpio = <&gpio3 19 0>;
> >                         enable-active-high;
> >                 };
> > +
> > +               reg_sensor: regulator@4 {
> 
> I know that you followed the existing pattern for regulators in this file, but it is
> not recommended to put regulators under "simple-bus".
> 
> I would suggest you to make a first patch of the series that removes all of the
> existing regulators from "simple-bus", then you add this series on top.
> 
> Then this regulator becomes:
> 
> reg_light_sensor: regulator-light-sensor {
> 
> > +                       compatible = "regulator-fixed";
> > +                       reg = <4>;
> > +                       pinctrl-names = "default";
> > +                       pinctrl-0 = <&pinctrl_sensor_reg>;
> 
> pinctrl_sensor_reg is too generic. You could use pinctrl_light_sensor_reg

As this regulator controls all the sensors power on board, including light sensor,
magnetometer sensor and accelerometer sensors, so I think it is better to
use "pinctrl_sensors_reg" instead of "pinctrl_light_sensor_reg", so I use
" pinctrl_sensors_reg" in V2 patch.

> 
> > +                       regulator-name = "sensor-supply";
> > +                       regulator-min-microvolt = <3300000>;
> > +                       regulator-max-microvolt = <3300000>;
> > +                       gpio = <&gpio2 31 GPIO_ACTIVE_HIGH>;
> > +                       enable-active-high;
> > +                       regulator-always-on;
> > +               };
> >         };
> >
> >         gpio-keys {
> > @@ -420,6 +433,15 @@
> >                 interrupts = <7 2>;
> >                 wakeup-gpios = <&gpio6 7 0>;
> >         };
> > +
> > +       isl29023@44 {
> 
> Node names should be generic, so: light-sensor@44

Improved it in V2 patch, and also apply the patch you sent me as
the first patch, please help review them, thanks.

Anson.