Re: [PATCH] pinctrl: Use of_node_name_eq for node name comparisons

[Tomasz Figa]

2018å12æ5æ(æ) 11:51 Rob Herring <robh@xxxxxxxxxx>:
>
> Convert string compares of DT node names to use of_node_name_eq helper
> instead. This removes direct access to the node name pointer.
>
> Cc: Tomasz Figa <tomasz.figa@xxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Cc: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: linux-samsung-soc@xxxxxxxxxxxxxxx
> Cc: linux-gpio@xxxxxxxxxxxxxxx
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---
>  drivers/pinctrl/samsung/pinctrl-samsung.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c
> index ee6ee2338606..de0477bb469d 100644
> --- a/drivers/pinctrl/samsung/pinctrl-samsung.c
> +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c
> @@ -1071,7 +1071,7 @@ samsung_pinctrl_get_soc_data(struct samsung_pinctrl_drv_data *d,
>                         continue;
>                 bank = d->pin_banks;
>                 for (i = 0; i < d->nr_banks; ++i, ++bank) {
> -                       if (!strcmp(bank->name, np->name)) {
> +                       if (of_node_name_eq(np, bank->name)) {
>                                 bank->of_node = np;
>                                 break;
>                         }
> --
> 2.19.1
>

Reviewed-by: Tomasz Figa <tomasz.figa@xxxxxxxxx>

Best regards,
Tomasz