Re: [PATCH 2/2] drm/ttm: Use pr_debug for all output from ttm_bo_evict

[Michel DÃnzer]

On 2018-12-06 3:43 a.m., Zhang, Jerry(Junwei) wrote:
> On 12/6/18 12:56 AM, Michel DÃnzer wrote:
>> From: Michel DÃnzer <michel.daenzer@xxxxxxx>
>>
>> All the output is related, so it should all be printed the same way.
>> Some of it was using pr_debug, but some of it appeared in dmesg by
>> default. The caller should handle failure, so there's no need to spam
>> dmesg with potentially quite a lot of output by default.
>>
>> Signed-off-by: Michel DÃnzer <michel.daenzer@xxxxxxx>
> Sounds reasonable, but personally prefer to show error when some
> vital incident happens, e.g. no memory on eviction.

The amdgpu driver still prints these in that case:

 [drm:amdgpu_cs_ioctl [amdgpu]] *ERROR* amdgpu_cs_list_validate(validated) failed.
 [drm:amdgpu_cs_ioctl [amdgpu]] *ERROR* Not enough memory for command submission!

That's plenty as far as I'm concerned. :)


-- 
Earthling Michel DÃnzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer