RE: [RFC PATCH v2 03/15] dt-bindings: add binding for USBSS-DRD controller.
From: Pawel Laszczak
Date: Thu Dec 06 2018 - 05:26:44 EST
Hi,
>On Sun, Nov 18, 2018 at 10:08:59AM +0000, Pawel Laszczak wrote:
>> Thsi patch aim at documenting USB related dt-bindings for the
>
>typo
>
>> Cadence USBSS-DRD controller.
>>
>> Signed-off-by: Pawel Laszczak <pawell@xxxxxxxxxxx>
>> ---
>> .../devicetree/bindings/usb/cdns3-usb.txt | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/usb/cdns3-usb.txt
>>
>> diff --git a/Documentation/devicetree/bindings/usb/cdns3-usb.txt b/Documentation/devicetree/bindings/usb/cdns3-usb.txt
>> new file mode 100644
>> index 000000000000..f9e953f32d47
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/usb/cdns3-usb.txt
>> @@ -0,0 +1,17 @@
>> +Binding for the Cadence USBSS-DRD controller
>> +
>> +Required properties:
>> + - reg: Physical base address and size of the controller's register area.
>
>1 or 3 regions? If 3, what is each one and the order?
I will add extra description.
>
>> + - compatible: Should contain: "cdns,usb3"
>
>Only one version and one set of bugs?
Yes, currently we have only one version.
>
>> + - interrupts: Interrupt specifier. Refer to interrupt bindings.
>
>How many interrupts?
Single line for Device/Host/OTG
I will add description
>
>> +
>> +
>> +Example:
>> + cdns3@f3000000 {
>
>usb@...
>
Ok.
>> + compatible = "cdns,usb3";
>> + interrupts = <USB_IRQ 7 IRQ_TYPE_LEVEL_HIGH>;
>> + reg = <0xf3000000 0x10000 //memory area for OTG/DRD registers
>> + 0xf3010000 0x10000 //memory area for HOST registers
>> + 0xf3020000 0x10000>; //memory area for Device registers
>> + };
>> +
>> --
>> 2.17.1
>>
Thanks,
Cheers
Pawel