[PATCH] scsi: message: fusion: Use kmemdup instead of duplicating its function
From: Wen Yang
Date: Thu Dec 06 2018 - 07:37:58 EST
kmemdup has implemented the function that kmalloc() + memcpy().
We prefer to kmemdup rather than code opened implementation.
This issue was detected with the help of coccinelle.
Signed-off-by: Wen Yang <wen.yang99@xxxxxxxxxx>
CC: Sathya Prakash <sathya.prakash@xxxxxxxxxxxx>
CC: Chaitra P B <chaitra.basappa@xxxxxxxxxxxx>
CC: Suganath Prabu Subramani <suganath-prabu.subramani@xxxxxxxxxxxx>
CC: MPT-FusionLinux.pdl@xxxxxxxxxxxx
CC: linux-scsi@xxxxxxxxxxxxxxx
CC: linux-kernel@xxxxxxxxxxxxxxx
---
drivers/message/fusion/mptbase.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c
index ba551d8dfba4..f8ec116cb9a4 100644
--- a/drivers/message/fusion/mptbase.c
+++ b/drivers/message/fusion/mptbase.c
@@ -6001,13 +6001,12 @@ mpt_findImVolumes(MPT_ADAPTER *ioc)
if (mpt_config(ioc, &cfg) != 0)
goto out;
- mem = kmalloc(iocpage2sz, GFP_KERNEL);
+ mem = kmemdup((u8 *)pIoc2, iocpage2sz, GFP_KERNEL);
if (!mem) {
rc = -ENOMEM;
goto out;
}
- memcpy(mem, (u8 *)pIoc2, iocpage2sz);
ioc->raid_data.pIocPg2 = (IOCPage2_t *) mem;
mpt_read_ioc_pg_3(ioc);
--
2.19.1