Re: [GIT PULL] Uprobes: Fix kernel oops with delayed_uprobe_remove()

[Andrew Morton]

On Thu, 6 Dec 2018 12:47:19 -0500 Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> 
>     Uprobes: Fix kernel oops with delayed_uprobe_remove()
>     
>     There could be a race between task exit and probe unregister:
>     
>       exit_mm()
>       mmput()
>       __mmput()                     uprobe_unregister()
>       uprobe_clear_state()          put_uprobe()
>       delayed_uprobe_remove()       delayed_uprobe_remove()
>     
>     put_uprobe() is calling delayed_uprobe_remove() without taking
>     delayed_uprobe_lock and thus the race sometimes results in a
>     kernel crash. Fix this by taking delayed_uprobe_lock before
>     calling delayed_uprobe_remove() from put_uprobe().
>     
>     Detailed crash log can be found at:
>       Link: http://lkml.kernel.org/r/000000000000140c370577db5ece@xxxxxxxxxx
>     
>     Link: http://lkml.kernel.org/r/20181205033423.26242-1-ravi.bangoria@xxxxxxxxxxxxx
>     
>     Acked-by: Oleg Nesterov <oleg@xxxxxxxxxx>
>     Reviewed-by: Srikar Dronamraju <srikar@xxxxxxxxxxxxxxxxxx>
>     Reported-by: syzbot+cb1fb754b771caca0a88@xxxxxxxxxxxxxxxxxxxxxxxxx
>     Fixes: 1cc33161a83d ("uprobes: Support SDT markers having reference count (semaphore)")
>     Signed-off-by: Ravi Bangoria <ravi.bangoria@xxxxxxxxxxxxx>
>     Signed-off-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>
> 

No cc:stable?