Re: [PATCH] perf script: Fix LBR skid dump problems in brstackinsn

From: Andi Kleen
Date: Thu Dec 06 2018 - 17:52:11 EST


On Thu, Dec 06, 2018 at 06:29:20PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Dec 06, 2018 at 12:51:48PM -0800, Andi Kleen escreveu:
> > On Thu, Dec 06, 2018 at 02:01:40PM -0300, Arnaldo Carvalho de Melo wrote:
> > > Em Mon, Nov 19, 2018 at 09:06:17PM -0800, Andi Kleen escreveu:
> > > > From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> > > >
> > > > This is a fix for another instance of the skid problem Milian
> > > > recently found [1]
>
> I think you forgot to add the reference, i.e. what is the url or
> message-id that this [1] refers to?

Hmm, I thought I saw some patches from Milian for this earlier,
but now I can't find them. Perhaps I misremember. Milian
can point to them if they exist and are not just a figment
of my imagination :-)

These were the changes to report the stack frame RIP/RSP in the PEBS
handler and use it for unwinding in perf.

-Andi