Re: [PATCH] riscv: remove unused variable in ftrace

From: Steven Rostedt
Date: Thu Dec 06 2018 - 20:07:49 EST


On Thu, 6 Dec 2018 11:20:31 -0800
Olof Johansson <olof@xxxxxxxxx> wrote:

> On Thu, Dec 6, 2018 at 2:26 AM David Abdurachmanov
> <david.abdurachmanov@xxxxxxxxx> wrote:
> >
> > Noticed while building kernel-4.20.0-0.rc5.git2.1.fc30 for
> > Fedora 30/RISCV.
> >
> > [..]
> > BUILDSTDERR: arch/riscv/kernel/ftrace.c: In function 'prepare_ftrace_return':
> > BUILDSTDERR: arch/riscv/kernel/ftrace.c:135:6: warning: unused variable 'err' [-Wunused-variable]
> > BUILDSTDERR: int err;
> > BUILDSTDERR: ^~~

Bah. I could have sworn I checked for all the error messages when I did
my cross-compiling of the architectures. I fixed this issue in other
places, not sure how I missed riscv.

Thanks for fixing it.

Acked-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>

-- Steve


> > [..]
> >
> > Signed-off-by: David Abdurachmanov <david.abdurachmanov@xxxxxxxxx>
>
> Please add a:
> Fixes: e949b6db51dc1 ("riscv/function_graph: Simplify with
> function_graph_enter()")
> Reviewed-by: Olof Johansson <olof@xxxxxxxxx>