Re: [PATCH v10 0/6] Support for Qualcomm UFS QMP PHY on SDM845

From: Kishon Vijay Abraham I
Date: Thu Dec 06 2018 - 23:32:10 EST


Hi,

On 05/12/18 12:31 PM, Vivek Gautam wrote:
> On Tue, Oct 23, 2018 at 10:07 AM Can Guo <cang@xxxxxxxxxxxxxx> wrote:
>>
>> This patch series adds support for UFS QMP PHY on SDM845 and the
>> compatible string for it. This patch series depends on the current
>> proposed QMP V3 USB3 UNI PHY support for sdm845 driver [1], on
>> the DT bindings for the QMP V3 USB3 PHYs based dirver [2], and also
>> rebased on updated pipe_clk initialization sequence [3]. This series
>> can only be merged once the dependent patches do.
>> [1] http://lists-archives.com/linux-kernel/29071659-dt-bindings-phy-qcom-qmp-update-bindings-for-sdm845.html
>> [2] http://lists-archives.com/linux-kernel/29071660-phy-qcom-qmp-add-qmp-v3-usb3-uni-phy-support-for-sdm845.html
>> [3] https://patchwork.kernel.org/patch/10376551/
>
> Besides my comment for PATCH 4/6, I have already reviewed the entire series,
> and it looks good.
> If adding new bindings for sdm845 needs a further review, can you separate out
> just the phy patches from this series (patch 1, 2, 3 & 6), and re-send them.
> We can ask Kishon if he can pull them in for this merge window.
> Thanks.

Looks like the PHY patches has gone in the previous merge window itself. If
there are any changes, please post only the diff as a separate patch.

Thanks
Kishon
>
> best regards
> Vivek
>
>>
>> Changes since v9:
>> - Incorporated review comments from Rob.
>>
>> Changes since v8:
>> - Add one new change to support ufs core reset.
>> - Incorporated review comments from Evan, Vivek.
>>
>> Changes since v7:
>> - Add one new change to update UFS PHY power on sequence
>> - Incorporated review comments from Evan, Vivek and Manu.
>>
>> Changes since v6:
>> - Add one new change to clean up some structs and field
>> - Updates the PHY power control sequence.
>> - Incorporated review comments from Vivek and Manu.
>>
>> Changes since v5:
>> - Updates the PHY power control sequence.
>> - Updates UFS PHY power on condition check.
>>
>> Changes since v4:
>> - Adds 'ref_aux' clock back to SDM845 UFS PHY clock list.
>> - Power on PHY before serdes configuration starts.
>> - Updates the UFS PHY initialization sequence.
>> - Updates a few UFS PHY registers.
>> - Incorporated review comments from Vivek and Manu.
>>
>> Changes since v3:
>> - Incorporated review comments from Vivek and Rob.
>>
>> Changes since v2:
>> - Incorporated review comments from Vivek and Rob.
>> - Remove "ref_aux" from sdm845 ufs phy clock list structure.
>>
>> Changes since v1:
>> - Incorporated review comments from Vivek and Manu.
>> - Update the commit title of patch 2.
>>
>> Can Guo (5):
>> phy: Update PHY power control sequence
>> phy: General struct and field cleanup
>> phy: Add QMP phy based UFS phy support for sdm845
>> scsi: ufs: Power on phy after it is initialized
>> dt-bindings: phy-qcom-qmp: Add UFS phy compatible string for sdm845
>>
>> Dov Levenglick (1):
>> scsi: ufs: Add core reset support
>>
>> .../devicetree/bindings/phy/qcom-qmp-phy.txt | 4 +-
>> drivers/phy/qualcomm/phy-qcom-qmp.c | 216 +++++++++++++++++++--
>> drivers/phy/qualcomm/phy-qcom-qmp.h | 15 ++
>> drivers/scsi/ufs/ufs-qcom.c | 34 +++-
>> drivers/scsi/ufs/ufs-qcom.h | 1 +
>> drivers/scsi/ufs/ufshcd-pltfrm.c | 22 +++
>> drivers/scsi/ufs/ufshcd.c | 13 ++
>> drivers/scsi/ufs/ufshcd.h | 12 ++
>> 8 files changed, 296 insertions(+), 21 deletions(-)
>>
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
>> a Linux Foundation Collaborative Project
>>
>
>