Re: [PATCH v1 4/4] phy: qcom-qmp: Expose provided clocks to DT

[Vivek Gautam]

On Fri, Nov 30, 2018 at 3:46 AM Evan Green <evgreen@xxxxxxxxxxxx> wrote:
>
> Register a simple clock provider for the PHY pipe clock sources so that
> device tree users can point at these clocks via phandles to the lane
> nodes.
>
> Signed-off-by: Evan Green <evgreen@xxxxxxxxxxxx>
> ---
>
>  drivers/phy/qualcomm/phy-qcom-qmp.c | 23 ++++++++++++++++++++++-
>  1 file changed, 22 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
> index 8204d55e2d650..b4006818e1b65 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
> @@ -1542,6 +1542,11 @@ static int qcom_qmp_phy_clk_init(struct device *dev)
>         return devm_clk_bulk_get(dev, num, qmp->clks);
>  }
>
> +static void phy_pipe_clk_release_provider(void *res)
> +{
> +       of_clk_del_provider(res);
> +}
> +
>  /*
>   * Register a fixed rate pipe clock.
>   *
> @@ -1588,7 +1593,23 @@ static int phy_pipe_clk_register(struct qcom_qmp *qmp, struct device_node *np)
>         fixed->fixed_rate = 125000000;
>         fixed->hw.init = &init;
>
> -       return devm_clk_hw_register(qmp->dev, &fixed->hw);
> +       ret = devm_clk_hw_register(qmp->dev, &fixed->hw);
> +       if (ret)
> +               return ret;
> +
> +       ret = of_clk_add_hw_provider(np, of_clk_hw_simple_get, &fixed->hw);
> +       if (ret)
> +               return ret;
> +
> +       /*
> +        * Roll a devm action because the clock provider is the child node, but
> +        * the child node is not actually a device.
> +        */
> +       ret = devm_add_action(qmp->dev, phy_pipe_clk_release_provider, np);
> +       if (ret)
> +               phy_pipe_clk_release_provider(np);
> +
> +       return ret;
>  }
>
>  static const struct phy_ops qcom_qmp_phy_gen_ops = {
> --
> 2.18.1
>

Tested on db820c [1]
Tested-by: Vivek Gautam <vivek.gautam@xxxxxxxxxxxxxx>

[1] https://github.com/vivekgautam1/linux/tree/origin/v4.20-rc5/db820c

BRs
Vivek

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation