Re: [ v3 3/3] mtd: rawnand: stm32_fmc2: add manual mode

From: Christophe Kerello
Date: Fri Dec 07 2018 - 05:57:39 EST


Hi Linus,

It is correct.
I will replace "manual mode" by "polling mode" in next patchset.

Regards,
Christophe Kerello.

On 12/7/18 10:16 AM, Linus Walleij wrote:
On Thu, Nov 29, 2018 at 5:42 PM Christophe Kerello
<christophe.kerello@xxxxxx> wrote:

This patch adds the manual mode, a basic mode that do not need
any DMA channels. This mode is also useful for debug purpose.

Signed-off-by: Christophe Kerello <christophe.kerello@xxxxxx>

This is a bit of drive-by comment, but "manual mode" usually
means there is a person "a man" pulling levers and pushing
buttons. There is nothing manual inside a computer system.

I think the more appropriate term is "polling mode" which is
what we call code that read registers directly waiting for status
flags rather than relying on IRQs or DMA flows.

Yours,
Linus Walleij