Re: [PATCH 18/22] mfd: wm831x-i2c: Make it explicitly non-modular

From: Paul Gortmaker
Date: Fri Dec 07 2018 - 13:17:00 EST


[Re: [PATCH 18/22] mfd: wm831x-i2c: Make it explicitly non-modular] On 05/12/2018 (Wed 11:38) Charles Keepax wrote:

> On Sun, Dec 02, 2018 at 11:23:25PM -0500, Paul Gortmaker wrote:

[...]

> > -static int wm831x_i2c_remove(struct i2c_client *i2c)
> > -{
> > - struct wm831x *wm831x = i2c_get_clientdata(i2c);
> > -
> > - wm831x_device_exit(wm831x);
>
> These patches remove the only callers of wm831x_device_exit, so I
> guess we should probably remove that function too?

Agreed. I've ammended the 831x-core patch to remove this as well.
Thanks for spotting it. Will send v3 shortly.

Paul.
--

>
> Thanks,
> Charles