Re: [PATCH 2/2] arm64: dts: ti: k3-am654-base-board: Add MMC/SD support

From: Nishanth Menon
Date: Sat Dec 08 2018 - 10:59:13 EST


On 14:12-20181207, Faiz Abbas wrote:

> +
> +&sdhci0 {
> + status = "okay";
> + pinctrl-names = "default";
> + pinctrl-0 = <&main_mmc0_pins_default>;
> + bus-width = <8>;
> + non-removable;
> + ti,driver-strength-ohm = <50>;

^^

> +};
> +
> +&sdhci1 {
> + status = "okay";
> + pinctrl-names = "default";
> + pinctrl-0 = <&main_mmc1_pins_default>;
> + ti,driver-strength-ohm = <50>;

NAK.

$ git checkout next-20181207
$ git grep ti,driver-strength-ohm Documentation
$

Nada.. And.. I think "new phy binding" probably introduces this.
[1] https://patchwork.kernel.org/project/linux-mmc/list/?series=53185

If your patches are'nt really ready, please send them as RFC, I am not
really in a mood to track the status of every single driver subsystem.

If your binding is not in linux next at the baremin, as far as I am
concerned, this is not ready, and should be RFC.

--
Regards,
Nishanth Menon