Re: [PATCH] leds: gpio: Drop unneeded manual of_node assignment

From: Jacek Anaszewski
Date: Sat Dec 08 2018 - 13:02:52 EST


Hi Krzysztof,

Thank you for the patch.

On 12/7/18 11:10 AM, Krzysztof Kozlowski wrote:
This reverts the main change of commit bff23714bc36 ("leds: leds-gpio:
Set of_node for created LED devices") because of_node assignment is
handled by core since commit 7ea79ae86c28 ("leds: gpio: use OF variant
of LED registering function"). Basically the code was overwriting the
of_node with same value.

No functional change expected.

Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
---
drivers/leds/leds-gpio.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
index 45e012093865..998f2ff6914d 100644
--- a/drivers/leds/leds-gpio.c
+++ b/drivers/leds/leds-gpio.c
@@ -190,7 +190,6 @@ static struct gpio_leds_priv *gpio_leds_create(struct platform_device *pdev)
fwnode_handle_put(child);
return ERR_PTR(ret);
}
- led_dat->cdev.dev->of_node = np;
priv->num_leds++;
}


Applied.

--
Best regards,
Jacek Anaszewski