Re: [PATCH v2 2/5] devfreq: add support for suspend/resume of a devfreq device
From: Pavel Machek
Date: Sun Dec 09 2018 - 04:00:16 EST
On Tue 2018-12-04 14:36:11, Chanwoo Choi wrote:
> Hi Lukasz,
>
> Looks good to me. But, I add the some comments.
> If you will fix it, feel free to add my tag:
> Reviewed-by: Chanwoo choi <cw00.choi@xxxxxxxxxxx>
>
> On 2018ë 12ì 03ì 23:31, Lukasz Luba wrote:
> > The patch prepares devfreq device for handling suspend/resume
> > functionality. The new fields will store needed information during this
>
> nitpick. Remove unneeded space. There are two spaces between '.' and 'The new'.
Yes. And that's because two spaces are okay at that place.
https://www.writersdigest.com/online-editor/how-many-spaces-after-a-period
Please don't cause unneeded noise on the list with trivial
comments. If the patch is okay, apply the patch, no need to find
trivial nit everywhere.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature