Re: Strange hang with gcc 8 of kprobe multiple_kprobes test
From: Ingo Molnar
Date: Sun Dec 09 2018 - 17:01:35 EST
* Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> On Tue, 4 Dec 2018 09:15:06 +0100
> Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
> > * Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
> >
> > > I remember I have fixed this, and actually WE did it :-D
> > >
> > > https://lkml.org/lkml/2018/8/23/1203
> > >
> > > Ah, we hit a same bug...
> > >
> > > Ingo, could you pick the patch? Should I resend it?
> >
> > Indeed: I just picked it up into tip:perf/urgent.
> >
> > It's my bad: I missed the original submission due to Steve's feedback
> > which I mistook as a request for another iteration, while he only
> > commented on the reason for the original breakage and gave his
> > Reviewed-by ...
> >
>
> Sorry for the confusion. The patch and code was quite complex, and I
> was documenting what I thought of the patch (and the bug), so that my
> Reviewed-by had a bit more meaning.
It was totally welcome when I read it the second time - and it's my bad I
was reading too quickly first time around ;-)
So please keep doing it whenever you find the time! :)
Thanks,
Ingo