[PATCH 3.16 007/328] USB: serial: sierra: fix potential deadlock at close

From: Ben Hutchings
Date: Sun Dec 09 2018 - 17:24:58 EST

3.16.62-rc1 review patch. If anyone has any objections, please let me know.


From: John Ogness <john.ogness@xxxxxxxxxxxxx>

commit e60870012e5a35b1506d7b376fddfb30e9da0b27 upstream.

The portdata spinlock can be taken in interrupt context (via
Disable interrupts when taking the portdata spinlock when discarding
deferred URBs during close to prevent a possible deadlock.

Fixes: 014333f77c0b ("USB: sierra: fix urb and memory leak on disconnect")
Signed-off-by: John Ogness <john.ogness@xxxxxxxxxxxxx>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
[ johan: amend commit message and add fixes and stable tags ]
Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
drivers/usb/serial/sierra.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/usb/serial/sierra.c
+++ b/drivers/usb/serial/sierra.c
@@ -772,9 +772,9 @@ static void sierra_close(struct usb_seri
- spin_lock(&portdata->lock);
+ spin_lock_irq(&portdata->lock);
- spin_unlock(&portdata->lock);
+ spin_unlock_irq(&portdata->lock);