Re: [PATCH -next] input: keyboard: remove duplicated include from mtk-pmic-keys.c

From: Lee Jones
Date: Mon Dec 10 2018 - 01:16:01 EST


On Sun, 09 Dec 2018, YueHaibing wrote:

> Remove duplicated include.
>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
> drivers/input/keyboard/mtk-pmic-keys.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/mtk-pmic-keys.c b/drivers/input/keyboard/mtk-pmic-keys.c
> index 02c67a1..5027ebb 100644
> --- a/drivers/input/keyboard/mtk-pmic-keys.c
> +++ b/drivers/input/keyboard/mtk-pmic-keys.c
> @@ -19,7 +19,6 @@
> #include <linux/input.h>
> #include <linux/interrupt.h>
> #include <linux/platform_device.h>
> -#include <linux/kernel.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> #include <linux/regmap.h>

You are removing the wrong one.

Please convert this patch's main intent to alphabetise the header
files. Then you can remove any obvious duplicates.

--
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog