Re: [PATCH v8 2/2] mfd: axp20x: Add supported cells for AXP803

From: Chen-Yu Tsai
Date: Mon Dec 10 2018 - 01:41:57 EST

On Mon, Dec 10, 2018 at 2:35 PM Lee Jones <lee.jones@xxxxxxxxxx> wrote:
> On Sat, 08 Dec 2018, Oskari Lemmela wrote:
> > Parts of the AXP803 are compatible with their counterparts on the AXP813.
> > These include the GPIO, ADC, AC and battery power supplies.
> >
> > Signed-off-by: Oskari Lemmela <oskari@xxxxxxxxxxx>
> > Reviewed-by: Chen-Yu Tsai <wens@xxxxxxxx>
> > Tested-by: Vasily Khoruzhick <anarsoul@xxxxxxxxx>
> > Signed-off-by: Chen-Yu Tsai <wens@xxxxxxxx>
> I'm happy to fix this, but ...
> Can you explain these tags for me please?
> Specifically the last one.
> Why does Chen-Yu Tsai have an SoB there?

I picked his patch to rebase off the previous one, and reworked the ordering.
I then pushed it onto GitHub [1], but didn't get around to sending it to the
mailing lists. Oskari said on IRC that he would handle it.

I'm not sure what would be appropriate here though? Oskari's first SoB should
be kept, since he's the original author. Maybe he should've added his SoB
again as the final entry? Either way I suppose it would be confusing without
any explanation.