KASAN: use-after-free Read in ___neigh_create

From: syzbot
Date: Mon Dec 10 2018 - 02:52:07 EST


syzbot found the following crash on:

HEAD commit: 83af01ba1c2d Merge branch 'tc-testing-next'
git tree: net-next
console output: https://syzkaller.appspot.com/x/log.txt?x=15562a43400000
kernel config: https://syzkaller.appspot.com/x/.config?x=28ecefa8a6e10719
dashboard link: https://syzkaller.appspot.com/bug?extid=e4d42eb35f6a27b0a628
compiler: gcc (GCC) 8.0.1 20180413 (experimental)

Unfortunately, I don't have any reproducer for this crash yet.

IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+e4d42eb35f6a27b0a628@xxxxxxxxxxxxxxxxxxxxxxxxx

BUG: KASAN: use-after-free in __list_add_valid+0x8f/0xac lib/list_debug.c:26
Read of size 8 at addr ffff8881b83e4bb0 by task syz-executor4/14957

CPU: 0 PID: 14957 Comm: syz-executor4 Not tainted 4.20.0-rc4+ #333
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x244/0x39d lib/dump_stack.c:113
print_address_description.cold.7+0x9/0x1ff mm/kasan/report.c:256
kasan_report_error mm/kasan/report.c:354 [inline]
kasan_report.cold.8+0x242/0x309 mm/kasan/report.c:412
__asan_report_load8_noabort+0x14/0x20 mm/kasan/report.c:433
__list_add_valid+0x8f/0xac lib/list_debug.c:26
__list_add include/linux/list.h:60 [inline]
list_add_tail include/linux/list.h:93 [inline]
neigh_alloc net/core/neighbour.c:395 [inline]
___neigh_create+0x14b7/0x2600 net/core/neighbour.c:553
__neigh_create+0x30/0x40 net/core/neighbour.c:640
ip_finish_output2+0xb8b/0x1860 net/ipv4/ip_output.c:224
ip_finish_output+0x7fd/0xfa0 net/ipv4/ip_output.c:317
NF_HOOK_COND include/linux/netfilter.h:278 [inline]
ip_mc_output+0x2c4/0x15b0 net/ipv4/ip_output.c:390
dst_output include/net/dst.h:444 [inline]
ip_local_out+0xc5/0x1b0 net/ipv4/ip_output.c:124
ip_send_skb+0x40/0xe0 net/ipv4/ip_output.c:1463
udp_send_skb.isra.46+0x6ad/0x1160 net/ipv4/udp.c:929
udp_sendmsg+0x2953/0x3c40 net/ipv4/udp.c:1216
udpv6_sendmsg+0x182c/0x36a0 net/ipv6/udp.c:1316
inet_sendmsg+0x1a1/0x690 net/ipv4/af_inet.c:798
sock_sendmsg_nosec net/socket.c:621 [inline]
sock_sendmsg+0xd5/0x120 net/socket.c:631
___sys_sendmsg+0x51d/0x930 net/socket.c:2116
__sys_sendmmsg+0x246/0x6d0 net/socket.c:2211
__do_sys_sendmmsg net/socket.c:2240 [inline]
__se_sys_sendmmsg net/socket.c:2237 [inline]
__x64_sys_sendmmsg+0x9d/0x100 net/socket.c:2237
do_syscall_64+0x1b9/0x820 arch/x86/entry/common.c:290
RIP: 0033:0x457569
Code: fd b3 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 cb b3 fb ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007fe6733c8c78 EFLAGS: 00000246 ORIG_RAX: 0000000000000133
RAX: ffffffffffffffda RBX: 0000000000000004 RCX: 0000000000457569
RDX: 04000000000001da RSI: 0000000020000080 RDI: 0000000000000004
RBP: 000000000072bf00 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00007fe6733c96d4
R13: 00000000004c3c33 R14: 00000000004d6248 R15: 00000000ffffffff

Allocated by task 14937:
save_stack+0x43/0xd0 mm/kasan/kasan.c:448
set_track mm/kasan/kasan.c:460 [inline]
kasan_kmalloc+0xc7/0xe0 mm/kasan/kasan.c:553
__do_kmalloc mm/slab.c:3722 [inline]
__kmalloc+0x15b/0x760 mm/slab.c:3731
kmalloc include/linux/slab.h:551 [inline]
kzalloc include/linux/slab.h:741 [inline]
neigh_alloc net/core/neighbour.c:375 [inline]
___neigh_create+0x13fc/0x2600 net/core/neighbour.c:553
neigh_add+0xbaa/0xd90 net/core/neighbour.c:1865
rtnetlink_rcv_msg+0x46a/0xc20 net/core/rtnetlink.c:4966
netlink_rcv_skb+0x172/0x440 net/netlink/af_netlink.c:2477
rtnetlink_rcv+0x1c/0x20 net/core/rtnetlink.c:4984
netlink_unicast_kernel net/netlink/af_netlink.c:1310 [inline]
netlink_unicast+0x5a5/0x760 net/netlink/af_netlink.c:1336
netlink_sendmsg+0xa18/0xfc0 net/netlink/af_netlink.c:1917
sock_sendmsg_nosec net/socket.c:621 [inline]
sock_sendmsg+0xd5/0x120 net/socket.c:631
___sys_sendmsg+0x7fd/0x930 net/socket.c:2116
__sys_sendmsg+0x11d/0x280 net/socket.c:2154
__do_sys_sendmsg net/socket.c:2163 [inline]
__se_sys_sendmsg net/socket.c:2161 [inline]
__x64_sys_sendmsg+0x78/0xb0 net/socket.c:2161
do_syscall_64+0x1b9/0x820 arch/x86/entry/common.c:290

Freed by task 14947:
save_stack+0x43/0xd0 mm/kasan/kasan.c:448
set_track mm/kasan/kasan.c:460 [inline]
__kasan_slab_free+0x102/0x150 mm/kasan/kasan.c:521
kasan_slab_free+0xe/0x10 mm/kasan/kasan.c:528
__cache_free mm/slab.c:3498 [inline]
kfree+0xcf/0x230 mm/slab.c:3817
__rcu_reclaim kernel/rcu/rcu.h:233 [inline]
rcu_do_batch kernel/rcu/tree.c:2437 [inline]
invoke_rcu_callbacks kernel/rcu/tree.c:2716 [inline]
rcu_process_callbacks+0x1140/0x1ac0 kernel/rcu/tree.c:2697
__do_softirq+0x308/0xb7e kernel/softirq.c:292

The buggy address belongs to the object at ffff8881b83e4940
which belongs to the cache kmalloc-1k of size 1024
The buggy address is located 624 bytes inside of
1024-byte region [ffff8881b83e4940, ffff8881b83e4d40)
The buggy address belongs to the page:
page:ffffea0006e0f900 count:1 mapcount:0 mapping:ffff8881da800ac0 index:0x0 compound_mapcount: 0
flags: 0x2fffc0000010200(slab|head)
raw: 02fffc0000010200 ffffea000666bf08 ffffea0006d00788 ffff8881da800ac0
raw: 0000000000000000 ffff8881b83e4040 0000000100000007 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
ffff8881b83e4a80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
ffff8881b83e4b00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
ffff8881b83e4b80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
ffff8881b83e4c00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
ffff8881b83e4c80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb

This bug is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@xxxxxxxxxxxxxxxxx

syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#bug-status-tracking for how to communicate with syzbot.