Re: [PATCH -next] USB: serial: mos7840: remove set but not used variables 'number, serial'

From: Johan Hovold
Date: Mon Dec 10 2018 - 04:24:09 EST


On Fri, Dec 07, 2018 at 02:50:42AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/usb/serial/mos7840.c: In function 'mos7840_send_cmd_write_baud_rate':
> drivers/usb/serial/mos7840.c:1584:16: warning:
> variable 'number' set but not used [-Wunused-but-set-variable]
>
> drivers/usb/serial/mos7840.c: In function 'mos7840_change_port_settings':
> drivers/usb/serial/mos7840.c:1695:21: warning:
> variable 'serial' set but not used [-Wunused-but-set-variable]
>
> 'number' never used since introduction in commit 3f5429746d91 ("USB: Moschip
> 7840 USB-Serial Driver")
>
> 'serial' not used since commit 5833041f1b13 ("USB: serial: remove unnecessary
> reinitialisations of urb->dev")
>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>

Applied for -next, thanks.

Johan