Re: [PATCH 16/18] mfd: wm8350-i2c: Make it explicitly non-modular

From: Charles Keepax
Date: Mon Dec 10 2018 - 04:28:14 EST

On Fri, Dec 07, 2018 at 03:11:03PM -0500, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
> drivers/mfd/Kconfig:config MFD_WM8350_I2C
> drivers/mfd/Kconfig: bool "Wolfson Microelectronics WM8350 with I2C"
> ...meaning that it currently is not being built as a module by anyone.
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
> We explicitly disallow a driver unbind, since that doesn't have a
> sensible use case anyway, and it allows us to drop the ".remove"
> code for non-modular drivers.
> Since module_init was not in use by this code, the init ordering
> remains unchanged with this commit.
> We don't replace module.h with init.h since the file already has that.
> But we do delete an unused moduleparam.h
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
> Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> Cc: patches@xxxxxxxxxxxxxxxxxxxxx
> Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
> ---
> -static int wm8350_i2c_remove(struct i2c_client *i2c)
> -{
> - struct wm8350 *wm8350 = i2c_get_clientdata(i2c);
> -
> - wm8350_device_exit(wm8350);

This is the only caller of this function so you probably want to
remove it in the next patch as we did for the 831x stuff.