Re: [PATCH] perf auxtrace: Alter addr_filter__entire_dso() to work if there are no symbols

From: Arnaldo Carvalho de Melo
Date: Mon Dec 10 2018 - 08:40:02 EST

Em Mon, Dec 10, 2018 at 03:17:05PM +0200, Adrian Hunter escreveu:
> On 27/11/18 2:42 PM, Arnaldo Carvalho de Melo wrote:
> > Em Tue, Nov 27, 2018 at 10:46:34AM +0200, Adrian Hunter escreveu:
> >> addr_filter__entire_dso() uses the first and last symbols from a dso,
> >> and so does not work when there are no symbols. Alter it to filter the
> >> whole file instead.

> > I'm splitting this patch into a first prep one that renames and exports
> > the static function dso__data_file_size() and a second that does what
> > this commig log message states.

> > The reason is that sometimes we find out that the main part of the patch
> > is wrong and we then decide to revert the patch, only to realize that
> > the exported function is by that time already used elsewhere.

> Thanks for looking at this, but did it get lost? I don't see it in your tree.

Yeah, my bad, thanks for the reminder, did the split and added to my
perf/core branch,

Also I'm adding this:

Cc: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
Cc: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>
Fixes: 1b36c03e3569 ("perf record: Add support for using symbols in address filters")

So that people that were involved in the patch that introduced this
feature gets notified of this fix, also for backporters to take notice,
please try to do this in the future.


- Arnaldo