Re: [PATCH v3 0/7] dma-debug cleanup and dynamic allocation

From: Qian Cai
Date: Mon Dec 10 2018 - 10:51:17 EST


On 12/10/18 9:00 AM, Robin Murphy wrote:
> Hi all,
>
> Here's some assorted cleanup and improvements to dma-debug which grew
> out of the problem that certain drivers use very large numbers of DMA
> mappings, and knowing when to override "dma_debug_entries=..." and what
> value to override it with can be a less-than-obvious task for users.
>
> The main part is patch #4, wherein we make dma-debug clever enough
> to allocate more entries dynamically if needed, such that the
> preallocation value becomes more of a quality-of-life option than a
> necessity. Patches #5 and #6 do some cruft-removal to allow patch #7
> to make the allocation behaviour more efficient in general.
>
> Patches #1, #2 and #4 are some other cleanup and handy features which
> fell out of the discussion/development.
>
> Robin.
>
>
> Robin Murphy (7):
> dma-debug: Use pr_fmt()
> dma-debug: Expose nr_total_entries in debugfs
> dma-debug: Dynamically expand the dma_debug_entry pool
> dma-debug: Make leak-like behaviour apparent
> x86/dma/amd-gart: Stop resizing dma_debug_entry pool
> dma/debug: Remove dma_debug_resize_entries()
> dma-debug: Batch dma_debug_entry allocation
>
> Documentation/DMA-API.txt | 20 +-
> Documentation/x86/x86_64/boot-options.txt | 5 +-
> arch/x86/kernel/amd_gart_64.c | 23 ---
> include/linux/dma-debug.h | 7 -
> kernel/dma/debug.c | 217 ++++++++++------------
> 5 files changed, 109 insertions(+), 163 deletions(-)
>

Tested-by: Qian Cai <cai@xxxxxx>