Re: [PATCH 1/2] locking/atomics: Change 'fold' to 'grep'

From: Will Deacon
Date: Mon Dec 10 2018 - 14:00:47 EST


On Mon, Dec 10, 2018 at 05:50:34PM +0000, Mark Rutland wrote:
> From: Anders Roxell <anders.roxell@xxxxxxxxxx>
>
> Some distibutions and build systems doesn't include 'fold' from
> coreutils default.
>
> .../scripts/atomic/atomic-tbl.sh: line 183: fold: command not found
>
> Rework to use 'grep' instead of 'fold' to use a dependency that is
> already used a lot in the kernel.
>
> Reported-by: Naresh Kamboju <naresh.kamboju@xxxxxxxxxx>
> Suggested-by: Will Deacon <will.deacon@xxxxxxx>
> Signed-off-by: Anders Roxell <anders.roxell@xxxxxxxxxx>
> [Mark: rework commit message]
> Signed-off-by: Mark Rutland <mark.rutland@xxxxxxx>
> ---
> scripts/atomic/atomic-tbl.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/atomic/atomic-tbl.sh b/scripts/atomic/atomic-tbl.sh
> index 9d6be538a987..81d5c32039dd 100755
> --- a/scripts/atomic/atomic-tbl.sh
> +++ b/scripts/atomic/atomic-tbl.sh
> @@ -180,7 +180,7 @@ gen_proto_variants()
> #gen_proto(meta, ...)
> gen_proto() {
> local meta="$1"; shift
> - for m in $(echo "${meta}" | fold -w1); do
> + for m in $(echo "${meta}" | grep -o .); do
> gen_proto_variants "${m}" "$@"
> done
> }

Acked-by: Will Deacon <will.deacon@xxxxxxx>

Will